mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] piiswrong commented on a change in pull request #10216: [WIP] [DO NOT MERGE] Onnx Model Zoo tests
Date Mon, 26 Mar 2018 19:33:44 GMT
piiswrong commented on a change in pull request #10216: [WIP] [DO NOT MERGE] Onnx Model Zoo
tests
URL: https://github.com/apache/incubator-mxnet/pull/10216#discussion_r177208408
 
 

 ##########
 File path: python/mxnet/contrib/onnx/_import/import_model.py
 ##########
 @@ -46,5 +43,5 @@ def import_model(model_file):
     except ImportError:
         raise ImportError("Onnx and protobuf need to be installed")
     model_proto = onnx.load(model_file)
-    sym, params = graph.from_onnx(model_proto.graph)
-    return sym, params
+    sym, arg_params, aux_params = graph.from_onnx(model_proto.graph)
+    return sym, arg_params, aux_params
 
 Review comment:
   The bigger issue here is you merged that ONNX PR without test coverage. Not even simple
cases like resnet was properly tested. Otherwise you would have found this issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message