From commits-return-24589-archive-asf-public=cust-asf.ponee.io@mxnet.incubator.apache.org Tue Feb 27 19:47:32 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id EE8C118066D for ; Tue, 27 Feb 2018 19:47:31 +0100 (CET) Received: (qmail 69572 invoked by uid 500); 27 Feb 2018 18:47:31 -0000 Mailing-List: contact commits-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list commits@mxnet.incubator.apache.org Received: (qmail 69561 invoked by uid 99); 27 Feb 2018 18:47:31 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Feb 2018 18:47:31 +0000 From: GitBox To: commits@mxnet.apache.org Subject: [GitHub] szha commented on a change in pull request #9893: Add constant parameter Message-ID: <151975725049.28771.4891420615814738056.gitbox@gitbox.apache.org> Date: Tue, 27 Feb 2018 18:47:30 -0000 szha commented on a change in pull request #9893: Add constant parameter URL: https://github.com/apache/incubator-mxnet/pull/9893#discussion_r171026215 ########## File path: python/mxnet/gluon/parameter.py ########## @@ -548,6 +588,45 @@ def get(self, name, **kwargs): setattr(param, k, v) return param + def get_constant(self, name, value=None): Review comment: When developing for a language model with weight drop, we took the approach of adding a new type of Parameter. While using the new WeightDropParameter, we found it quite difficult as user to properly change the type of parameter in the ParameterDict. Since this is a common use case too, should we be open to adding a getter function for such parameter as well? Or should we consider a different pattern? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services