From commits-return-22569-archive-asf-public=cust-asf.ponee.io@mxnet.incubator.apache.org Mon Feb 5 20:39:27 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 7B50D180647 for ; Mon, 5 Feb 2018 20:39:27 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 6B0D4160C3B; Mon, 5 Feb 2018 19:39:27 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7D38B160C5C for ; Mon, 5 Feb 2018 20:39:26 +0100 (CET) Received: (qmail 849 invoked by uid 500); 5 Feb 2018 19:39:25 -0000 Mailing-List: contact commits-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list commits@mxnet.incubator.apache.org Received: (qmail 796 invoked by uid 99); 5 Feb 2018 19:39:25 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Feb 2018 19:39:25 +0000 From: GitBox To: commits@mxnet.apache.org Subject: [GitHub] yzhliu commented on a change in pull request #9678: [First cut] Scala Inference APIs Message-ID: <151785956515.1484.818885865009982266.gitbox@gitbox.apache.org> yzhliu commented on a change in pull request #9678: [First cut] Scala Inference APIs URL: https://github.com/apache/incubator-mxnet/pull/9678#discussion_r166087804 ########## File path: scala-package/infer/src/main/scala/ml/dmlc/mxnet/infer/MXNetHandler.scala ########## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package ml.dmlc.mxnet.infer + +import java.util.concurrent._ + +trait MXNetHandler { + + def execute[T](f: => T): T + + val executor: ExecutorService + +} + +object MXNetHandlerType extends Enumeration { + + type MXNetHandlerType = Value + val SingleThreadHandler = Value("MXNetSingleThreadHandler") + val OneThreadPerModelHandler = Value("MXNetOneThreadPerModelHandler") +} + +class MXNetOneThreadPerModelHandler extends MXNetHandler { + + private val threadFactory = new ThreadFactory { + + override def newThread(r: Runnable): Thread = new Thread(r) { + setName(classOf[MXNetOneThreadPerModelHandler].getCanonicalName) + } + } + + override val executor: ExecutorService = Executors.newFixedThreadPool(10, threadFactory) + + override def execute[T](f: => T): T = { + val task = new Callable[T] { + override def call(): T = { + // scalastyle:off println + println("threadId: %s".format(Thread.currentThread().getId())) + // scalastyle:on println + f + } + } + val result = executor.submit(task) + try { + result.get() + } + catch { + case e: ExecutionException => throw e.getCause() + } + } + +} + +object MXNetSingleThreadHandler extends MXNetOneThreadPerModelHandler { + +} + +object MXNetHandler { + + def apply(): MXNetHandler = { + if (handlerType == MXNetHandlerType.OneThreadPerModelHandler) { + new MXNetOneThreadPerModelHandler + } + else { Review comment: place `else` the same line of `}` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services