mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] szha commented on a change in pull request #9893: Add constant parameter
Date Tue, 27 Feb 2018 18:47:30 GMT
szha commented on a change in pull request #9893: Add constant parameter
URL: https://github.com/apache/incubator-mxnet/pull/9893#discussion_r171026215
 
 

 ##########
 File path: python/mxnet/gluon/parameter.py
 ##########
 @@ -548,6 +588,45 @@ def get(self, name, **kwargs):
                     setattr(param, k, v)
         return param
 
+    def get_constant(self, name, value=None):
 
 Review comment:
   When developing for a language model with weight drop, we took the approach of adding a
new type of Parameter. While using the new WeightDropParameter, we found it quite difficult
as user to properly change the type of parameter in the ParameterDict. Since this is a common
use case too, should we be open to adding a getter function for such parameter as well? Or
should we consider a different pattern?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message