mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] marcoabreu commented on issue #9677: Refactor operators and add MKLDNN
Date Thu, 01 Jan 1970 00:00:00 GMT
marcoabreu commented on issue #9677: Refactor operators and add MKLDNN
URL: https://github.com/apache/incubator-mxnet/pull/9677#issuecomment-366042988
 
 
   To me, it really sounds like there are quite a decent number of known issues but for whatever
reason, there's a push to get this merged. Honestely, I'm afraid of this being PR being merged
and disabled tests and features being forgotten and thus increasing technical debt, which
in the end is going to harm our users. Especially if we are aware that for example operator
tuning is broken on Windows, it's IMO not the right thing to just disable the test or the
entire feature in the default CMake config. If a user wants to test the feature, it will hang
for them and we will probably have forgotten about it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message