mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] reminisce commented on a change in pull request #9681: Better Exception Handling for Operators
Date Thu, 01 Jan 1970 00:00:00 GMT
reminisce commented on a change in pull request #9681: Better Exception Handling for Operators
URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165574053
 
 

 ##########
 File path: include/mxnet/engine.h
 ##########
 @@ -182,7 +182,7 @@ class MXNET_API Engine {
                          std::vector<VarHandle> const& mutable_vars,
                          FnProperty prop = FnProperty::kNormal,
                          int priority = 0,
-                         const char* opr_name = nullptr) = 0;
+                         const char* opr_name = nullptr, bool wait = false) = 0;
 
 Review comment:
   1. Add `\param` for `wait` in doc.
   2. Put `bool wait...` in the next line to keep the coding style consistent with the existing
context. Same all the following changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message