mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] DickJC123 opened a new pull request #9674: Fix test_sparse_operator failures due to out-of-bounds ref.
Date Thu, 01 Jan 1970 00:00:00 GMT
DickJC123 opened a new pull request #9674: Fix test_sparse_operator failures due to out-of-bounds
ref.
URL: https://github.com/apache/incubator-mxnet/pull/9674
 
 
   ## Description ##
   
   One of our python2 mxnet containers showed test failures in test_sparse_operator.py:test_sparse_storage_fallback
 .  The root cause was traced to an out-of-bounds array reference of the 'axis' shape.  The
only supported axis shapes for the given 'csr' storage type reduction are (0,) and (1,). 
A check that the axis shape dimension is 1 before accessing shape[0] was added, solving the
problem.
   
   ## Checklist ##
   ### Essentials ###
   - [X] Passed code style checking (`make lint`)
   - [X] Changes are complete (i.e. I finished coding on this PR)
   - [X] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed
kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option
with NCCL)
   - [X] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented.

   - For new examples, README.md is added to explain the what the example does, the source
of the dataset, expected performance on test set and reference to the original paper if applicable
   - [X] To the my best knowledge, examples are either not affected by this change, or have
been fixed to be compatible with this change
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message