mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] cjolivier01 opened a new pull request #8989: Symbol __getitem__ using list_outputs() is too expensive
Date Thu, 01 Jan 1970 00:00:00 GMT
cjolivier01 opened a new pull request #8989: Symbol __getitem__ using list_outputs() is too
expensive
URL: https://github.com/apache/incubator-mxnet/pull/8989
 
 
   Symbol __getitem__ using list_outputs() is too expensive, when it only cares about the
output count in most cases
   
   ## Description ##
   
   Profile hotspot, expensive call of Symbol.list_outputs()
   
   ![list_outputs_profiling](https://user-images.githubusercontent.com/11234557/33741873-f55916ee-db5a-11e7-95b9-241c49cee65f.png)
   
   
   ## Checklist ##
   ### Essentials ###
   - [ ] Passed code style checking (`make lint`)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage
   - [ ] For user-facing API changes, API doc string has been updated. For new C++ functions
in header files, their functionalities and arguments are well-documented. 
   - [ ] To my best knowledge, examples are either not affected by this change, or have been
fixed to be compatible with this change
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message