Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8D57F200D44 for ; Mon, 20 Nov 2017 20:25:25 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8BF6C160BF9; Mon, 20 Nov 2017 19:25:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C9179160BE1 for ; Mon, 20 Nov 2017 20:25:24 +0100 (CET) Received: (qmail 96639 invoked by uid 500); 20 Nov 2017 19:25:24 -0000 Mailing-List: contact commits-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list commits@mxnet.incubator.apache.org Received: (qmail 96630 invoked by uid 99); 20 Nov 2017 19:25:24 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Nov 2017 19:25:24 +0000 From: GitBox To: commits@mxnet.apache.org Subject: [GitHub] anirudh2290 commented on a change in pull request #8725: [WIP] Fix custom op when used with need_top_grad=False Message-ID: <151120592337.3906.3627627937847389154.gitbox@gitbox.apache.org> archived-at: Mon, 20 Nov 2017 19:25:25 -0000 anirudh2290 commented on a change in pull request #8725: [WIP] Fix custom op when used with need_top_grad=False URL: https://github.com/apache/incubator-mxnet/pull/8725#discussion_r152086978 ########## File path: python/mxnet/operator.py ########## @@ -563,7 +563,7 @@ def infer_storage_type_backward(self, in_stype): list of aux stypes calculated from in_stype, in the same order as declared in list_auxiliary_states. """ - return in_stype, [in_stype[0]]*len(self.list_outputs()), \ + return in_stype, [in_stype[0]]*len(self.list_arguments()), \ Review comment: the argument in_stype is a list of storage types for out_grad, in_data, out_data. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services