Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 24F1D200D4C for ; Thu, 16 Nov 2017 02:41:55 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 23C4B160C09; Thu, 16 Nov 2017 01:41:55 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6AEB0160BF4 for ; Thu, 16 Nov 2017 02:41:54 +0100 (CET) Received: (qmail 20721 invoked by uid 500); 16 Nov 2017 01:41:53 -0000 Mailing-List: contact commits-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list commits@mxnet.incubator.apache.org Received: (qmail 20703 invoked by uid 99); 16 Nov 2017 01:41:53 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Nov 2017 01:41:53 +0000 From: GitBox To: commits@mxnet.apache.org Subject: [GitHub] eric-haibin-lin commented on a change in pull request #8620: Support sparse for custom python operators Message-ID: <151079651293.6617.801454902188455366.gitbox@gitbox.apache.org> archived-at: Thu, 16 Nov 2017 01:41:55 -0000 eric-haibin-lin commented on a change in pull request #8620: Support sparse for custom python operators URL: https://github.com/apache/incubator-mxnet/pull/8620#discussion_r151302276 ########## File path: tests/python/unittest/test_operator.py ########## @@ -3570,12 +3570,19 @@ def test_rcbrt_op(): def test_custom_op(): class Sqr(mx.operator.CustomOp): def forward(self, is_train, req, in_data, out_data, aux): - self.assign(out_data[0], req[0], in_data[0]*in_data[0]) - aux[0][:] = 1 + #self.assign(out_data[0], req[0], in_data[0]*in_data[0]) Review comment: Remove unused code? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services