mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] KellenSunderland opened a new pull request #8554: Dont Merge - Disable problem tests
Date Thu, 01 Jan 1970 00:00:00 GMT
KellenSunderland opened a new pull request #8554: Dont Merge - Disable problem tests
URL: https://github.com/apache/incubator-mxnet/pull/8554
 
 
   ## Description ##
   As discussed here in a few threads, segmenting tests will go a long way in stabilizing
our CI.  This PR is a WIP that aims to remove some of the most problematic tests.  All tests
ignored here either crashed on a P3 instance with the release version (r 0.12) of mxnet from
the deep learning AMI, or they took longer to run than a minute.  With these tests removed
all tests were running in less than 2 minutes on a P3.
   
   Tests are removed with test annotations (aka decorators).  Initially I've only used ```@nightly```
to indicate a test that would best be run on a nightly basis and ```@crashing``` to indicate
a crashing test.  I'd propose we open issues for all crashing tests, assign owners and leave
the tests ignored for the time being in the test suite.  I'd also like to discuss what the
correct set of test annotations should be.  Should we consider ```@cuda_test```, ```@high_mem```
or ```@http_required``` test annotations for example?  Once we've decorated tests with annotations
we can selectively choose to run them by passing the -a arg to nose (as shown in the new Jenkinsfile).
   
   ## Checklist ##
   ### Essentials ###
   - [ ] Passed code style checking (`make lint`)  (not run)
   - [ ] Changes are complete (i.e. I finished coding on this PR) (WIP)
   - [ ] All changes have test coverage (removes tests)
   - [x] For user-facing API changes, API doc string has been updated.
   - [x] To my best knowledge, examples are either not affected by this change, or have been
fixed to be compatible with this change
   
   ### Changes ###
   - [x] Remove problem tests (slow running or crashing).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message