mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rahul003 opened a new pull request #8507: Passing user specified environment variables when using launch.py
Date Thu, 01 Jan 1970 00:00:00 GMT
rahul003 opened a new pull request #8507: Passing user specified environment variables when
using launch.py
URL: https://github.com/apache/incubator-mxnet/pull/8507
 
 
   ## Description ##
   Passes additional user specific environment variables when using launch.py. This is very
helpful in passing variables like PYTHONPATH, MXNET_ENGINE_TYPE. I think this makes launching
jobs for distributed training easier. 
   
   If you have suggestions for a different name, please let me know.
   The current usage is ```--pass-env A,B,C```.
   
   Requires this PR in dmlc-core to be merged https://github.com/dmlc/dmlc-core/pull/324
   
   Provides a way to solve this issue apache/incubator-mxnet#7857
   
   ## Checklist ##
   ### Essentials ###
   - [ ] Passed code style checking (`make lint`)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage
   - [ ] For user-facing API changes, API doc string has been updated.
   - [ ] To my best knowledge, examples are either not affected by this change, or have been
fixed to be compatible with this change
   
   ### Changes ###
   - [ ] Add additional arg in launch.py
   - [ ] Make dmlc_tracker submit function to accept this variable
   
   ## Comments ##
   - I've only tested this with local and ssh. Not tested this with yarn, mpi, sge since I
don't have those environments set up. But I think this should work even in those environments.
Or should I remove them and only support local and ssh?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message