mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] cjolivier01 commented on a change in pull request #8342: [WIP] 2bit gradient compression
Date Thu, 01 Jan 1970 00:00:00 GMT
cjolivier01 commented on a change in pull request #8342: [WIP] 2bit gradient compression
URL: https://github.com/apache/incubator-mxnet/pull/8342#discussion_r145988864
 
 

 ##########
 File path: src/kvstore/kvstore_local.h
 ##########
 @@ -135,6 +135,13 @@ class KVStoreLocal : public KVStore {
     PullRowSparseImpl(keys, val_rowids, priority);
   }
 
+  void SetCompress(const std::string& compress, const float neg_threshold,
+                   const float pos_threshold) override {
+    compress_ = compress;
+    pos_threshold_ = pos_threshold;
 
 Review comment:
   I wasn't implying the check should be made here -- I just thought of it here.  If you're
checking it somewhere that will catch it early, that's fine with me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message