Mailing-List: contact users-help@mina.apache.org; run by ezmlm
Precedence: bulk
Reply-To: users@mina.apache.org
Received-SPF: pass (nike.apache.org: domain of pdcvgmh@gmail.com designates
 209.85.211.186 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=JHxxMd7kT8L7gmE468xvqFOIrdCPyz4NAas4mS2B2df00kRlHXy5vMmDJaGTKimqW4
         aOtxaI78pQZgqi29MY56AvUbNlcMT5+w+/rFbwLPynMk6/JIQucsObMfRmPKKOIGc7Ge
         MVtNZf6cVRz4oU17FB9OA99NRv83xU3+w64b0=
MIME-Version: 1.0
In-Reply-To: <b6db25ac0907300533x288e01a3ya0681163ae62ea63@mail.gmail.com>
References: <b6db25ac0907291943t764450d7n2746542a198b365f@mail.gmail.com>
	 <b6db25ac0907300533x288e01a3ya0681163ae62ea63@mail.gmail.com>
Date: Fri, 7 Aug 2009 13:43:57 -0300
Message-ID: <b6db25ac0908070943v5ab2e9fdn1009f549af7c8494@mail.gmail.com>
Subject: Re: CumulativeProtocolDecoder problem [MINA Version 2.0.0-M6]
From: pablo caballero <pdcvgmh@gmail.com>
To: users@mina.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

My mistake. I was throwing an exception from the decode method that is
not a RecoverableProtocolDecoderException subclass

On Thu, Jul 30, 2009 at 9:33 AM, pablo caballero<pdcvgmh@gmail.com> wrote:
> Correction: the malformed message is the third message.
>
> Update: If msg3 is a well formed short (~100 bytes) message everything
> works fine. I think that the exception has something to do with the
> error.
>
> Best regards
>
> On Wed, Jul 29, 2009 at 11:43 PM, pablo caballero<pdcvgmh@gmail.com> wrot=
e:
>> Hi, I have a problem with one of my mina based applications.
>>
>> Source code where the problem manifests itself:
>>
>> import org.apache.commons.logging.Log;
>> import org.apache.commons.logging.LogFactory;
>> import org.apache.mina.core.buffer.IoBuffer;
>> import org.apache.mina.core.session.IoSession;
>> import org.apache.mina.filter.codec.CumulativeProtocolDecoder;
>> import org.apache.mina.filter.codec.ProtocolDecoderOutput;
>> import org.jpos.iso.ISOMsg;
>> import org.jpos.iso.ISOPackager;
>>
>> public class TandemProtocolDecoder extends CumulativeProtocolDecoder {
>>
>> =A0 =A0 =A0 =A0private static final int MAX_MESSAGE_SIZE =3D 4196;
>> =A0 =A0 =A0 =A0private Log logger =3D LogFactory.getLog(TandemProtocolDe=
coder.class);
>>
>> =A0 =A0 =A0 =A0private ISOPackager isoPackager;
>>
>> =A0 =A0 =A0 =A0public TandemProtocolDecoder(ISOPackager isoPackager) {
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0super();
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0this.isoPackager =3D isoPackager;
>> =A0 =A0 =A0 =A0}
>>
>> =A0 =A0 =A0 =A0public ISOPackager getIsoPackager() {
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return isoPackager;
>> =A0 =A0 =A0 =A0}
>>
>> =A0 =A0 =A0 =A0public void setIsoPackager(ISOPackager isoPackager) {
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0this.isoPackager =3D isoPackager;
>> =A0 =A0 =A0 =A0}
>>
>> =A0 =A0 =A0 =A0public TandemProtocolDecoder() {
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0super();
>> =A0 =A0 =A0 =A0}
>>
>> =A0 =A0 =A0 =A0@Override
>> =A0 =A0 =A0 =A0protected boolean doDecode(IoSession session, IoBuffer in=
,
>> ProtocolDecoderOutput out) throws Exception {
>>
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0String s =3D new String( in.array() );
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0logger.debug("Choclo:" + s =A0);
>>
>> =A0 =A0 =A0 =A0 =A0 =A0if (in.prefixedDataAvailable(2, MAX_MESSAGE_SIZE)=
) {
>>
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0int length =3D in.getUnsi=
gnedShort();
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0byte[] bytes =3D new byte=
[length];
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0in.get(bytes);
>>
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0ISOMsg isoMsg =3D new ISO=
Msg();
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0isoMsg.setPackager( isoPa=
ckager );
>>
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0//TODO Si no puede realiz=
ar el unpack lanza ISOException y entra
>> por exceptionCaught del conector
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0//Ver somo manejarlo
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0isoMsg.unpack( bytes );
>>
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0out.write(isoMsg);
>>
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return true;
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0}
>> =A0 =A0 =A0 =A0 =A0 =A0else{
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return false;
>> =A0 =A0 =A0 =A0 =A0 =A0}
>> =A0 =A0 =A0 =A0}
>>
>> }
>>
>> Problem description:
>>
>> 1.- The application message (tcp payload) consist in two bytes
>> indicating the size of the data and the data itself.
>> 2.- I have a test application that sends five messages to the mina appli=
cation:
>> * Message 1 (700 bytes - well formed)
>> * Message 2 (100 bytes - purposely malformed ISO message)
>> * Message 3 (700 bytes - well formed)
>> * Message 4 (700 bytes - well formed)
>> * Message 5 (700 bytes - well formed)
>> 3.- An IoBuffer (size =3D 2048) is fullfilled with msg1, msg2, msg3 and
>> a chunk of msg4
>> 4.- msg1 and msg2 are processed correctly (unpacked to a isomsg and
>> writed to the output)
>> 5.- The unpacking of msg3 throws and exception ( isoMsg.unpack( bytes
>> ) ) as expected. This exception is handled by the exceptionCaught in
>> the IoHandler
>> 6.- In the next call of the doDecode method the IoBuffer is filled
>> with rest of msg4 and msg5 (the beginning of the msg4 is lost). This
>> cause that 2 bytes of the msg4's data are considered
>> as the data size of the next message (in this case the data size,
>> wrongly deducted, =A0is >>> MAX_MESSAGE_SIZE and the
>> prefixedDataAvailable method throws an BufferDataException exception)
>>
>> Can someone tell me if there is an error in my code, is this the
>> expected behaviour (some workaround?) or if it is a bug?
>>
>> Thank you very much in advance
>>
>> Sorry for my bad English
>>
>> Best regards
>>
>