mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roberto Deandrea (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (SSHD-849) Possible race condition for local port forwarding channels
Date Tue, 06 Nov 2018 14:51:00 GMT

     [ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Roberto Deandrea closed SSHD-849.
    Resolution: Fixed

Hi Lyor,
You can consider good your master code. We made a mistake during our test phase so our latest
code is NOT needed to make things work for us.

Very sorry for wasting your precious time!!


> Possible race condition for local port forwarding channels
> ----------------------------------------------------------
>                 Key: SSHD-849
>                 URL: https://issues.apache.org/jira/browse/SSHD-849
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 2.1.1
>            Reporter: Roberto Deandrea
>            Assignee: Goldstein Lyor
>            Priority: Major
>             Fix For: 2.1.1
> Hi Lyor,
> We found another critical race condition sending data through local port forwarding channels
that causes loosing data bytes sent by client to target server.
> As soon as possible I will open a pull request with our potential changes to fix this
> I let you know when done because I would like to know your feedback.
>  Hi Lyor,
> We made some code changes to your proposed solution based on ClientChannelPendingMessageQueue.
> You can find our commit at https://github.com/robertodeandrea/mina-sshd/commit/4523138ee2b4efa483bc956e8769eafb13eff05d
> Can you review our code and give us feedback ?
> If it satisfies you can you merge it in Apache SSHD master repository ?
> Our definitive working code is at https://github.com/robertodeandrea/mina-sshd/commit/c381e522dc254387009d82612dc15f0c584dece6
> Cheers.
> Roberto
> Cheers
> Roberto
> The code changes against master code are :
> https://github.com/robertodeandrea/myclone/commit/0602840140ce82f51446b0d5a05fb409e730adad

This message was sent by Atlassian JIRA

View raw message