Mailing-List: contact dev-help@mina.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mina.apache.org
MIME-Version: 1.0
References: <ad42c55b-deee-d492-5215-7046e005bf44@macd.com>
 <1930c332-b611-6fcb-1a13-59325d10e1d6@macd.com> <9867fd0f-7a2b-ebf7-e0ff-db03f54eb414@gmail.com>
 <ea5cbe4f-d0a6-17ea-8a3f-ee74c7f5a6ca@macd.com> <2cbc7593-a89c-c200-cd9e-ff0032e934d7@macd.com>
 <3ef9f5b6-50a3-2792-82a2-9cb610aa3773@gmail.com> <2a5ac02c-4aaf-6f6b-4246-d35c3965d672@macd.com>
 <CAHohF3DttfGKDFvd8SzXVxSv7097KFFTKi8X80qYffy4_QoVjA@mail.gmail.com>
 <CAHohF3A076rrFazqH35D+HTAfTGP=WN68ECVmD9y=mcWy2jS0Q@mail.gmail.com>
 <43797407-783a-2b2e-2683-ff40813517f3@macd.com> <CAHohF3BCvnW9YxHor+QEkCwkfc_GkzjS01CQ1S2tka4+zBYXNg@mail.gmail.com>
 <cbb92ed2-97e4-38f6-0192-abbf3a3774ca@macd.com> <cd75e711-9972-214c-8c4b-72455da10411@gmail.com>
 <3dc99f03-09db-bd0a-4408-4dc00c2eb6d5@macd.com> <a9ce02b0-7b28-c31f-bb31-2b96d3c35ca1@gmail.com>
 <CAHohF3D+UjSWg9AqcApZdiLJ+s1O_TKhfbdDvwXXEKaiY7A9jw@mail.gmail.com>
 <8d3ba112-dc9c-ee15-3cf7-7c29a3c16104@macd.com> <ca1406cb-e992-0c27-7194-7ff9e7435427@gmail.com>
 <01385e39-fdbe-ea65-4f60-c245f7e49406@macd.com>
In-Reply-To: <01385e39-fdbe-ea65-4f60-c245f7e49406@macd.com>
From: Jonathan Valliere <jon.valliere@emoten.com>
Date: Mon, 16 Oct 2017 14:20:24 +0000
Message-ID: <CAHohF3B=0bi1wQM9sAfiTbciNBk40FL4+9LrA3hgf3FhO9kLZA@mail.gmail.com>
Subject: Re: leaking NioProcessors/NioSocketConnectors hanging in call to dispose
To: christoph.john@macd.com, dev@mina.apache.org
Content-Type: multipart/alternative; boundary="001a114630e6b2e4bd055baab507"
archived-at: Mon, 16 Oct 2017 14:20:46 -0000

--001a114630e6b2e4bd055baab507
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

If you can figure out a reproducible test case then I'm sure that we can
fix it.

On Mon, Oct 16, 2017 at 10:01 AM Christoph John <christoph.john@macd.com>
wrote:

> Hi Emmanuel,
>
> yes, but unfortunately it did not help.
>
> Thanks,
> Chris.
>
>
> On 16/10/17 15:41, Emmanuel L=C3=A9charny wrote:
> > Hi Christoph,
> >
> >
> > have you tried with this patch ? :
> >
> >
> > diff --git
> >
> a/mina-core/src/main/java/org/apache/mina/core/polling/AbstractPollingIoP=
rocessor.java
> >
> b/mina-core/src/main/java/org/apache/mina/core/polling/AbstractPollingIoP=
rocessor.java
> > index 50ebd4e..575b2f4 100644
> > ---
> >
> a/mina-core/src/main/java/org/apache/mina/core/polling/AbstractPollingIoP=
rocessor.java
> > +++
> >
> b/mina-core/src/main/java/org/apache/mina/core/polling/AbstractPollingIoP=
rocessor.java
> > @@ -695,8 +695,9 @@
> >                           for (Iterator<S> i =3D allSessions();
> i.hasNext();) {
> >                               IoSession session =3D i.next();
> >
> > +                            scheduleRemove((S) session);
> > +
> >                               if (session.isActive()) {
> > -                                scheduleRemove((S) session);
> >                                   hasKeys =3D true;
> >                               }
> >                           }
> >
> >
> > Le 16/10/2017 =C3=A0 14:41, Christoph John a =C3=A9crit :
> >> Hi Emmanuel, Jonathan,
> >>
> >> thanks for your patches. Unfortunately neither of them does correct
> >> the problem I am facing.
> >> I'd suggest that I'll try to reproduce this with a MINA-based test
> >> first. Otherwise it is probably just guess-work.
> >>
> >> Thanks for your help and best regards,
> >> Chris.
> >>
> >>
> >> On 11/10/17 16:14, Jonathan Valliere wrote:
> >>> Basically my proposed patch moves the check dispose conditional into =
a
> >>> finally loop forcing it to run even if exceptions were caught.
> >>>
> >>> If the SSLFilter did something weird then it would be blocked on that
> >>> filter. What is happening is that the Processor is not dying as
> >>> requested.
> >>> That's why I think my patch ought to resolve the problem.
> >>>
> >>> On Wed, Oct 11, 2017 at 10:05 AM Emmanuel L=C3=A9charny <
> elecharny@gmail.com>
> >>> wrote:
> >>>
> >>>> Le 11/10/2017 =C3=A0 14:51, Christoph John a =C3=A9crit :
> >>>>> Thanks, will try. Did this patch apply to 2.0.16? The line numbers =
do
> >>>>> not match. I have added it manually in line 1162 and removed the
> >>>>> statement from line 1164.
> >>>> It's for 2.0.17-SNAPSHOT, so you may have differences with 2.0.16, b=
ut
> >>>> minor.
> >>>>
> >>>> The idea here is to remove a session when it's i teh list of managed
> >>>> version, even if it's not valid (that might be a corner case when te=
h
> >>>> SSLFilter does not properly handle an exception and close the channe=
l.
> >>>> Call it a workaround atm)
> >>>>
> >>>> --
> >>>> Emmanuel Lecharny
> >>>>
> >>>> Symas.com
> >>>> directory.apache.org
> >>>>
> >>>>
>
> --
> Christoph John
> Development & Support
> Direct: +49 241 557080-28
> Mailto:Christoph.John@macd.com
>
>
>
> http://www.macd.com <http://www.macd.com/>
>
> -------------------------------------------------------------------------=
---------------------------
>
>
> -------------------------------------------------------------------------=
---------------------------
> MACD GmbH
> Oppenhoffallee 103
> D-52066 Aachen
> Tel: +49 241 557080-0 | Fax: +49 241 557080-10
>          Amtsgericht Aachen: HRB 8151
> Ust.-Id: DE 813021663
>
> Gesch=C3=A4ftsf=C3=BChrer: George Macdonald
>
> -------------------------------------------------------------------------=
---------------------------
>
>
> -------------------------------------------------------------------------=
---------------------------
>
> take care of the environment - print only if necessary
>

--001a114630e6b2e4bd055baab507--