Mailing-List: contact dev-help@mina.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mina.apache.org
From: jonnyzzz <git@git.apache.org>
To: dev@mina.apache.org
Reply-To: dev@mina.apache.org
Message-ID: <git-pr-23-mina-sshd@git.apache.org>
Subject: [GitHub] mina-sshd pull request: added protected #doVerify in
 AbstractSigna...
Content-Type: text/plain
Date: Fri, 12 Feb 2016 15:06:35 +0000 (UTC)

GitHub user jonnyzzz opened a pull request:

    https://github.com/apache/mina-sshd/pull/23

    added protected #doVerify in AbstractSignature

    In the scope of https://issues.apache.org/jira/browse/SSHD-642 I was working to create an inheritor of the SignatureRSA class in order to add padding bytes before verify method is called. Adding the overridable protected method (doVerify) should makes it possible to avoid code duplication from my side.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jonnyzzz/mina-sshd master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/mina-sshd/pull/23.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23
    
----
commit d6d7115469f44febca63eac2cade09a46d67e3c7
Author: Eugene Petrenko <eugene.petrenko@gmail.com>
Date:   2016-02-12T15:03:10Z

    extract protected #doVerify in AbstractSignature. Allows to include workaroungs for SSHD-642 easily without logic copy-paste

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---