mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guillaume Nodet (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (SSHD-439) Re-use read buffer in Nio2Session
Date Mon, 30 Mar 2015 08:25:54 GMT

     [ https://issues.apache.org/jira/browse/SSHD-439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Guillaume Nodet resolved SSHD-439.
----------------------------------
       Resolution: Fixed
    Fix Version/s: 1.0.0
         Assignee: Guillaume Nodet

https://git-wip-us.apache.org/repos/asf?p=mina-sshd.git;a=commitdiff;h=eb4fc83d6e4c5c881bde90d01a50ca9103f98951

> Re-use read buffer in Nio2Session
> ---------------------------------
>
>                 Key: SSHD-439
>                 URL: https://issues.apache.org/jira/browse/SSHD-439
>             Project: MINA SSHD
>          Issue Type: Improvement
>    Affects Versions: 1.0.0
>            Reporter: Goldstein Lyor
>            Assignee: Guillaume Nodet
>             Fix For: 1.0.0
>
>         Attachments: 0041-SSHD-439-Re-use-read-buffer-in-Nio2Session.patch
>
>
> The original asynchronous calls recursively _startReading()_ upon successful handling
of the incoming message. This means that a **new** _ByteBuffer_ of size 32K is created every
time this happens (not to mention a new object reference for the _Readable_ wrapper). Obviously,
we can (and should) re-use the buffer once handling of the previous message is completed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message