mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davidje13 <...@git.apache.org>
Subject [GitHub] mina-sshd pull request: [SSHD-108] Implemented callback for succes...
Date Sat, 21 Feb 2015 20:36:09 GMT
GitHub user davidje13 opened a pull request:

    https://github.com/apache/mina-sshd/pull/11

    [SSHD-108] Implemented callback for successful file uploads

    Implements the behaviour I suggested here: https://issues.apache.org/jira/browse/SSHD-108?focusedCommentId=14330308&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14330308
to allow successful uploads to be distinguished from aborted or failed uploads. This version
is the non-API breaking version (optional interface), which seems to be better all-round.
The majority of the new code is for the unit test, which required wrapping the file system
factory, view and file to provide a custom stream for the test.
    
    The test org.apache.sshd.ServerTest.testServerIdleTimeoutWithForce(ServerTest.java:246)
fails on my machine, but this is unrelated to the patch.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/davidje13/mina-sshd master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/mina-sshd/pull/11.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11
    
----
commit 495a9c86811051b06d2ae36e18c40db10152f0c6
Author: David Evans <davidje13@gmail.com>
Date:   2015-02-21T20:12:45Z

    Added optional interface for file uploads which confirms completed uploads (to distinguish
aborted/failed transfers)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message