Return-Path: Delivered-To: apmail-mina-dev-archive@www.apache.org Received: (qmail 84766 invoked from network); 17 Feb 2011 10:08:16 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 17 Feb 2011 10:08:16 -0000 Received: (qmail 37723 invoked by uid 500); 17 Feb 2011 10:08:16 -0000 Delivered-To: apmail-mina-dev-archive@mina.apache.org Received: (qmail 37429 invoked by uid 500); 17 Feb 2011 10:08:12 -0000 Mailing-List: contact dev-help@mina.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mina.apache.org Delivered-To: mailing list dev@mina.apache.org Received: (qmail 37421 invoked by uid 99); 17 Feb 2011 10:08:11 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Feb 2011 10:08:11 +0000 X-ASF-Spam-Status: No, hits=4.0 required=5.0 tests=FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,HTML_FONT_FACE_BAD,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of zyzy257@gmail.com designates 209.85.210.171 as permitted sender) Received: from [209.85.210.171] (HELO mail-iy0-f171.google.com) (209.85.210.171) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Feb 2011 10:08:05 +0000 Received: by iyh42 with SMTP id 42so2412870iyh.2 for ; Thu, 17 Feb 2011 02:07:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:date:message-id:subject:from:to :content-type; bh=QfxXzuE9OYrwFjhmgRFBDG+UUd9cW0mjqRZ1jVRvc0A=; b=qDLy0QWLAKDvm08x61p/ixLyD2kKmX1//tKAQya4Kdv3ALtMKnv57IW/D+oPwIjr7O EVLSAnPAADLTFnAxivFTsFebeluoiQZJuQ+34eZ2t26J/JtSIHhAcdL3ZkDQmPcSGjFi oCdr3h18glejy6j3E0oV0AQzSq6sDXJnD3Dz0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=Vaufh7zVR3N7gN4zA9wuXEB2YMIBWrgQBOTDrggLrUQs3pc9GkD/X2tq/qkST7pJH6 P/ks8AIlpuPL8OXscWtJ3s3x0Q9F+RJnNmdvM87NoNWhISxTqGuwSfpFQi0p/iKcuIe2 /HxRVAgYk2Hlwf9Kf7zU0HKxCo0vxUSMkrQvQ= MIME-Version: 1.0 Received: by 10.42.240.69 with SMTP id kz5mr2344102icb.468.1297937264249; Thu, 17 Feb 2011 02:07:44 -0800 (PST) Received: by 10.42.133.202 with HTTP; Thu, 17 Feb 2011 02:07:44 -0800 (PST) Date: Thu, 17 Feb 2011 18:07:44 +0800 Message-ID: Subject: Is that a bug in ReferenceCountingFilter? From: =?UTF-8?B?5Y2g57+8?= To: dev@mina.apache.org Content-Type: multipart/alternative; boundary=20cf3054a16d938c3d049c779133 --20cf3054a16d938c3d049c779133 Content-Type: text/plain; charset=UTF-8 hello It's seem like a bug in org.apache.mina.filter.util.ReferenceCountingFilter * public synchronized void onPreAdd(IoFilterChain parent, String name,* * NextFilter nextFilter) throws Exception {* * if (0 == count) {* * filter.init();* *++count;* ** * }* ** * * * filter.onPreAdd(parent, name, nextFilter);* * }* it cause the filter not work well. I think the code should be *public synchronized void onPreAdd(IoFilterChain parent, String name,* * NextFilter nextFilter) throws Exception {* * if (0 == count) {* * filter.init();* ** * }* *++count;* ** * * * filter.onPreAdd(parent, name, nextFilter);* * }* ** Is that a bug ? --20cf3054a16d938c3d049c779133--