Mailing-List: contact dev-help@mina.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mina.apache.org
Received-SPF: pass (nike.apache.org: domain of elecharny@gmail.com designates
 209.85.161.43 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:reply-to:user-agent:mime-version:to:subject
         :references:in-reply-to:content-type:content-transfer-encoding;
        b=i1sDeAkdUW2aiw7J904BmuufkJjNuDzvXuPrd/qlV2qnThj6NMTDjZNtitWNuwhpog
         zUlt8jQBANRANKzt50NVB6rj2EO4GkVDul0CngPQYFnLdeEOW6NOjDEE/p0j72QJU1Sq
         XN9Y7IV8VKt9ptAM+aSB05S3ay+A9sY8jmraE=
Message-ID: <4D5CFB40.3020005@gmail.com>
Date: Thu, 17 Feb 2011 11:41:04 +0100
From: Emmanuel Lecharny <elecharny@gmail.com>
Reply-To: elecharny@apache.org
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US;
 rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7
MIME-Version: 1.0
To: dev@mina.apache.org
Subject: Re: Is that a bug in ReferenceCountingFilter?
References: <AANLkTimxY6oESj4Rik+GhnaZR1Yh8UH8XN5ZFRM4id2Z@mail.gmail.com>
In-Reply-To: <AANLkTimxY6oESj4Rik+GhnaZR1Yh8UH8XN5ZFRM4id2Z@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 2/17/11 11:07 AM, 占翼 wrote:
> hello
>
> It's seem like a bug in org.apache.mina.filter.util.ReferenceCountingFilter
>
>    * public synchronized void onPreAdd(IoFilterChain parent, String name,*
> *            NextFilter nextFilter) throws Exception {*
> *        if (0 == count) {*
> *            filter.init();*
> *++count;*
> **
> *        }*
> **
> *        *
> *        filter.onPreAdd(parent, name, nextFilter);*
> *    }*
> it cause the filter not work well.
>
> I think the code should be
> *public synchronized void onPreAdd(IoFilterChain parent, String name,*
> *            NextFilter nextFilter) throws Exception {*
> *        if (0 == count) {*
> *            filter.init();*
> **
> *        }*
> *++count;*
> **
> *        *
> *        filter.onPreAdd(parent, name, nextFilter);*
> *    }*
> **
> Is that a bug ?
>
Ok, got it. The ugly formatting made me think that the count++ was 
outside the { }.

Good catch. Will fix it in 2.0.3.

Can you still create a JIRA so that I can close it ? It will be listed 
in the released bug fixed when the release will be issued.

Many thanks !

-- 
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com