Return-Path: Delivered-To: apmail-mina-dev-archive@www.apache.org Received: (qmail 67579 invoked from network); 1 Dec 2009 10:46:35 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 1 Dec 2009 10:46:35 -0000 Received: (qmail 31873 invoked by uid 500); 1 Dec 2009 10:46:34 -0000 Delivered-To: apmail-mina-dev-archive@mina.apache.org Received: (qmail 31785 invoked by uid 500); 1 Dec 2009 10:46:33 -0000 Mailing-List: contact dev-help@mina.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mina.apache.org Delivered-To: mailing list dev@mina.apache.org Received: (qmail 31775 invoked by uid 99); 1 Dec 2009 10:46:32 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Dec 2009 10:46:32 +0000 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [62.142.5.116] (HELO emh06.mail.saunalahti.fi) (62.142.5.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Dec 2009 10:46:22 +0000 Received: from saunalahti-vams (vs3-12.mail.saunalahti.fi [62.142.5.96]) by emh06-2.mail.saunalahti.fi (Postfix) with SMTP id A1919C7DA3; Tue, 1 Dec 2009 12:46:01 +0200 (EET) Received: from emh07.mail.saunalahti.fi ([62.142.5.117]) by vs3-12.mail.saunalahti.fi ([62.142.5.96]) with SMTP (gateway) id A02E997C6F1; Tue, 01 Dec 2009 12:46:01 +0200 Received: from anubis.fi.indagon.com (gw.indagon.com [194.241.175.120]) by emh07.mail.saunalahti.fi (Postfix) with ESMTP id 5D1AF1C6382; Tue, 1 Dec 2009 12:45:59 +0200 (EET) Received: from [127.0.0.1] (anubis [127.0.0.1]) by anubis.fi.indagon.com (8.13.8/8.13.8) with ESMTP id nB1AjvIX030530; Tue, 1 Dec 2009 12:45:58 +0200 Message-ID: <4B14F40D.8070106@indagon.com> Date: Tue, 01 Dec 2009 12:46:37 +0200 From: Eero Nevalainen User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: "dev@mina.apache.org" , "elecharny@apache.org" Subject: Re: about the implementation of SimpleIoProcessorPool References: <773890820911300230q72371b59u2ff2306be8dcb699@mail.gmail.com> <4B13D12F.9090400@indagon.com> In-Reply-To: X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Antivirus: VAMS X-Virus-Checked: Checked by ClamAV on apache.org Emmanuel Lecharny wrote: >>> The test is just a safety belt. It does not harm... We should >>> probably refactor this code to be a bit moe accurate though ... >> >> assert? > > Yuck :/ > > So C-ished.. > > better have better code ! Wait... what? I thought the whole point of assertions is to provide these "no harm safety belt checks", with the side effect that they can be disabled if there are concerns of efficiency. -- Eero Nevalainen