Mailing-List: contact dev-help@mina.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mina.apache.org
Received-SPF: pass (athena.apache.org: domain of sop@google.com designates
 216.239.33.17 as permitted sender)
DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns;
	h=date:from:to:subject:message-id:references:mime-version:
	content-type:content-disposition:content-transfer-encoding:in-reply-to:
	user-agent:x-system-of-record;
	b=tlvqrihV4obcxIpOtDKTuz5nk5ED7bUO7Hys+g6cMBwAxygieoIenZCVwdc8OTSkB
	Ur8sU7eTJZRaRiHd0/ZyA==
Date: Tue, 15 Dec 2009 06:56:00 -0800
From: Shawn Pearce <sop@google.com>
To: dev@mina.apache.org
Subject: Re: svn commit: r890631 - in
	/mina/sshd/trunk/sshd-core/src/main/java/org/apache/sshd:
	client/auth/ client/channel/ client/kex/ client/session/ common/
	common/channel/ common/session/ server/auth/ server/channel/
	server/session/
Message-ID: <20091215145600.GJ16591@google.com>
References: <20091215035633.5C97A23889ED@eris.apache.org>
 <b23ecedc0912150356y311f3fa3u1e864ba939e11540@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b23ecedc0912150356y311f3fa3u1e864ba939e11540@mail.gmail.com>
User-Agent: Mutt/1.5.17+20080114 (2008-01-14)

Guillaume Nodet <gnodet@gmail.com> wrote:
> I wonder if we should add back the createBuffer method with a single
> argument that would call createBuffer(cmd, 0) for readability...

I thought about doing that when I wrote the change... but since
Session is an interface I wasn't too thrilled about exposing two
different createBuffer methods in it.

Its easy enough for me to change though, I can back out most of
the patch and add the createBuffer(int) signature if that's what
you'd prefer.
 
> On Tue, Dec 15, 2009 at 04:56,  <spearce@apache.org> wrote:
> > Author: spearce
> > Date: Tue Dec 15 03:56:32 2009
> > New Revision: 890631
...
> > Unfortunately most uses of createBuffer don't care about the size
> > of the buffer, as they are one-shot requests which are often within
> > the default size of 512 bytes. �Pass in 0 for these and allow them
> > to use the default 512 byte size.