Return-Path: Delivered-To: apmail-mina-dev-archive@www.apache.org Received: (qmail 73485 invoked from network); 1 Dec 2009 15:31:39 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 1 Dec 2009 15:31:39 -0000 Received: (qmail 68513 invoked by uid 500); 1 Dec 2009 15:31:38 -0000 Delivered-To: apmail-mina-dev-archive@mina.apache.org Received: (qmail 68449 invoked by uid 500); 1 Dec 2009 15:31:38 -0000 Mailing-List: contact dev-help@mina.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mina.apache.org Delivered-To: mailing list dev@mina.apache.org Received: (qmail 68439 invoked by uid 99); 1 Dec 2009 15:31:38 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Dec 2009 15:31:38 +0000 X-ASF-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_SORBS_WEB X-Spam-Check-By: apache.org Received-SPF: softfail (athena.apache.org: transitioning domain of list@toolazydogs.com does not designate 209.85.216.204 as permitted sender) Received: from [209.85.216.204] (HELO mail-px0-f204.google.com) (209.85.216.204) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Dec 2009 15:31:36 +0000 Received: by pxi42 with SMTP id 42so3764819pxi.5 for ; Tue, 01 Dec 2009 07:31:15 -0800 (PST) Received: by 10.115.67.30 with SMTP id u30mr11226998wak.119.1259681473917; Tue, 01 Dec 2009 07:31:13 -0800 (PST) Received: from ?192.168.1.102? (dagmar.corp.linkedin.com [69.28.149.29]) by mx.google.com with ESMTPS id 23sm608887pxi.1.2009.12.01.07.31.11 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 01 Dec 2009 07:31:12 -0800 (PST) Message-Id: <0C922CAC-297C-497C-AA7A-1AB1C8D390DE@toolazydogs.com> From: "Alan D. Cabrera" To: dev@mina.apache.org In-Reply-To: <4B14F40D.8070106@indagon.com> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v936) Subject: Re: about the implementation of SimpleIoProcessorPool Date: Tue, 1 Dec 2009 07:31:09 -0800 References: <773890820911300230q72371b59u2ff2306be8dcb699@mail.gmail.com> <4B13D12F.9090400@indagon.com> <4B14F40D.8070106@indagon.com> X-Mailer: Apple Mail (2.936) On Dec 1, 2009, at 2:46 AM, Eero Nevalainen wrote: > Emmanuel Lecharny wrote: >>>> The test is just a safety belt. It does not harm... We should >>>> probably refactor this code to be a bit moe accurate though ... >>> >>> assert? >> >> Yuck :/ >> >> So C-ished.. >> >> better have better code ! > > Wait... what? > > I thought the whole point of assertions is to provide these "no harm > safety belt checks", with the side effect that they can be disabled if > there are concerns of efficiency. I personally like asserts for that reason and for the way it declares the original developer's assumptions. It's quite helpful when a new developer starts reading the code base. Finally, it does make code testing more productive in an open source environment where there are many cooks in the kitchen. Regards, Alan