mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eero Nevalainen <eero.nevalai...@indagon.com>
Subject Re: about the implementation of SimpleIoProcessorPool
Date Mon, 30 Nov 2009 14:05:35 GMT
Emmanuel Lecharny wrote:
> On Mon, Nov 30, 2009 at 11:30 AM, Peng Lee <pengli.hust@gmail.com> wrote:
>>      In my opinion,the line 176 [if (processorConstructor == null) ]
>> is redundant, because if processorConstructor is null, a
>> NullPointerException should be trowed previously. So, I think we
>> should remove the redundant code here.
>>  Of course, maybe there are any other things that i haven't knew
>> about, and who knows?
> 
> 
> The test is just a safety belt. It does not harm... We should probably
> refactor this code to be a bit moe accurate though ...

assert?

-- 
Eero Nevalainen


Mime
View raw message