mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeroen Brattinga <jeroen.bratti...@gmail.com>
Subject Re: [poll] New name for WrappingFilter
Date Wed, 07 Nov 2007 15:40:05 GMT
In that case CommonEventIoFilter is a better option, IMO.

(I don't get the 'combining' part in the EventCombiningIoFilter, since
there really is no combine action involved).


Jeroen Brattinga


On Wed, 2007-11-07 at 10:18 +0100, Maarten Bosteels wrote:
> yes, that's better than what we had until now
> I change my vote :-)
> 
> +1 EventCombiningIoFilter
> 
> Thanks,
> Maarten
> 
> On Nov 7, 2007 10:11 AM, Eero Nevalainen <eero.nevalainen@indagon.com>
> wrote:
> 
> > I think it'd be nicer to have something that ends with IoFilter.
> > So one more shot at naming the bugger:
> >
> > EventCombiningIoFilter
> >
> > -Eero
> >
> > Mike Heath wrote:
> > > +1 CommonIoEventFilter
> > >
> > > It seams like there may be a better name for this but
> > > CommonIoEventFilter would be fine.
> > >
> > > -Mike
> > >
> > > Maarten Bosteels wrote:
> > >> It's hard to come up with a good name for this beast, I'd welcome all
> > new
> > >> suggestions :-)
> > >> For now, this is my vote:
> > >>
> > >> +1 CommonIoEventFilter
> > >>
> > >> Maarten
> > >>
> > >> On 11/6/07, Trustin Lee <trustin@gmail.com> wrote:
> > >>> Hi folks,
> > >>>
> > >>> WrappingFilter is a new utility abstract IoFilter for those who want
> > >>> to filter all events in a single filter method:
> > >>>
> > >>>
> > >>>
> > http://svn.apache.org/viewvc/mina/trunk/core/src/main/java/org/apache/mina/filter/util/WrappingFilter.java?view=markup
> > >>>
> > >>> One known usage is here:
> > >>>
> > >>>
> > >>>
> > http://svn.apache.org/viewvc/mina/trunk/core/src/main/java/org/apache/mina/filter/logging/MdcInjectionFilter.java?view=markup
> > >>>
> > >>> However, WrappingFilter doesn't represent what it does exactly, so
we
> > >>> need a new name.  So far, the following names were suggested:
> > >>>
> > >>> * GenericIoFilter
> > >>> * SameActionForEveryIoEventTypeFilter
> > >>> * CommonIoEventFilter
> > >>> * SingletonActionIoFilter
> > >>> * MuxingIoFilter - (see http://en.wikipedia.org/wiki/Multiplexing)
> > >>> * CrossCuttingIoFilter - (see
> > >>> http://en.wikipedia.org/wiki/Cross-cutting_concern)
> > >>>
> > >>> Please feel free to add your suggestion or to cast a vote.  I'd like
> > >>> to see some consensus anyway.
> > >>>
> > >>> Trustin
> > >>> --
> > >>> what we call human nature is actually human habit
> > >>> --
> > >>> http://gleamynode.net/
> > >>> --
> > >>> PGP Key ID: 0x0255ECA6
> > >>>
> > >
> >
> >


Mime
View raw message