mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Trustin Lee (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DIRMINA-203) The performance of LoggingFilter is pool.
Date Thu, 06 Apr 2006 02:23:45 GMT
    [ http://issues.apache.org/jira/browse/DIRMINA-203?page=comments#action_12373452 ] 

Trustin Lee commented on DIRMINA-203:
-------------------------------------

Your fix looks very nice.  It would be perfect if you post a patch files against the latest
version.  It seems like you modified an older version (0.9.2).  The latest version should
look like:

if(SessionLog.isInfoEnabled(session)) {
    SessionLog.info( session, "RECEIVED: " + message ); 
}

> The performance of LoggingFilter is pool.
> -----------------------------------------
>
>          Key: DIRMINA-203
>          URL: http://issues.apache.org/jira/browse/DIRMINA-203
>      Project: Directory MINA
>         Type: Improvement

>     Versions: 0.9.3
>     Reporter: Xu Liang
>  Attachments: LoggingFilter.java, SessionLog.java
>
> The LoggingFilter's original code :
>     SessionLog.info( session, "RECEIVED: " + message );
> If the logger was disable It called the toString() of message.
> So I have writed new SessionLog whose interface like slf4j.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message