From issues-return-28594-archive-asf-public=cust-asf.ponee.io@metron.apache.org Tue May 19 20:01:51 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6F39B180638 for ; Tue, 19 May 2020 22:01:51 +0200 (CEST) Received: (qmail 79876 invoked by uid 500); 19 May 2020 20:01:50 -0000 Mailing-List: contact issues-help@metron.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@metron.apache.org Delivered-To: mailing list issues@metron.apache.org Received: (qmail 79867 invoked by uid 99); 19 May 2020 20:01:50 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 May 2020 20:01:50 +0000 From: =?utf-8?q?GitBox?= To: issues@metron.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bmetron-bro-plugin-kafka=5D_JonZeolla_commented_on_?= =?utf-8?q?pull_request_=2346=3A_METRON-2343_Bro_Kafka_plugin_-_ability_to_d?= =?utf-8?q?ynamically_modify_JSON?= Message-ID: <158991851077.19379.358623564307048723.asfpy@gitbox.apache.org> Date: Tue, 19 May 2020 20:01:50 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: JonZeolla commented on pull request #46: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/46#issuecomment-631050619 Looks good. Noticed we are lacking btests - I'm fine with having that as a follow-on. +1 pending JIRA creation ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org