metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kaspersorensen <...@git.apache.org>
Subject [GitHub] metamodel pull request #182: Add Create, Update, Delete functionality for HB...
Date Thu, 14 Jun 2018 12:35:00 GMT
Github user kaspersorensen commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/182#discussion_r195404505
  
    --- Diff: hbase/src/main/java/org/apache/metamodel/hbase/HBaseDataContext.java ---
    @@ -242,17 +240,18 @@ protected DataSet materializeMainSchemaTable(Table table, List<Column>
columns,
         }
     
         private void setMaxRows(Scan scan, int maxRows) {
    -        try {
    -            // in old versions of the HBase API, the 'setMaxResultSize' method
    -            // is not available
    -            Method method = scan.getClass().getMethod("setMaxResultSize", long.class);
    -            method.invoke(scan, (long) maxRows);
    --- End diff --
    
    Oh, good to know :-) Then the change certainly makes sense.


---

Mime
View raw message