metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kaspersorensen <...@git.apache.org>
Subject [GitHub] metamodel pull request #182: Add Create, Update, Delete functionality for HB...
Date Tue, 12 Jun 2018 22:58:38 GMT
Github user kaspersorensen commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/182#discussion_r194912619
  
    --- Diff: hbase/src/main/java/org/apache/metamodel/hbase/HBaseFamilyMap.java ---
    @@ -106,9 +105,9 @@ public String toString() {
                 if (sb.length() > 1) {
                     sb.append(',');
                 }
    -            sb.append(Arrays.toString(entry.getKey()));
    +            sb.append(new String(entry.getKey()));
                 sb.append('=');
    -            sb.append(Arrays.toString(entry.getValue()));
    +            sb.append(new String(entry.getValue()));
    --- End diff --
    
    Isn't this problematic, since the byte-array may not be a string, and it may not even
be decodeable as a string, so this could throw.


---

Mime
View raw message