metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arjansh <...@git.apache.org>
Subject [GitHub] metamodel pull request #179: Feature/neo4j column types
Date Tue, 22 May 2018 14:15:06 GMT
Github user arjansh commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/179#discussion_r189893280
  
    --- Diff: neo4j/src/main/java/org/apache/metamodel/neo4j/Neo4jDataContext.java ---
    @@ -236,8 +256,8 @@ protected String getMainSchemaName() throws MetaModelException {
             }
         }
     
    -    private List<JSONObject> getOutgoingRelationshipsPerNode(Integer nodeId) {
    -        List<JSONObject> outgoingRelationshipsPerNode = new ArrayList<JSONObject>();
    +    private List<JSONObject> getOutgoingRelationshipsPerNode(final Integer nodeId)
{
    +        List<JSONObject> outgoingRelationshipsPerNode = new ArrayList<>();
    --- End diff --
    
    If you improve this line of code, why not make the variable `final` too?


---

Mime
View raw message