metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From LosD <...@git.apache.org>
Subject [GitHub] metamodel pull request #165: METAMODEL-1165: Add alias default table
Date Wed, 01 Nov 2017 19:59:54 GMT
Github user LosD commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/165#discussion_r148367755
  
    --- Diff: core/src/test/java/org/apache/metamodel/QueryPostprocessDataContextTest.java
---
    @@ -60,6 +60,49 @@
         private final Table table1 = schema.getTableByName(TABLE_CONTRIBUTOR);
         private final Table table2 = schema.getTableByName(TABLE_ROLE);
     
    +    public void testSchemaTraversalWithAliasTable() {
    +        final MockUpdateableDataContext dc = new MockUpdateableDataContext();
    +        
    +        final Column column = dc.getColumnByQualifiedLabel("foo");
    +        assertEquals("table", column.getTable().getName());
    +    }
    +    
    --- End diff --
    
    I'm a bit missing a test to check that the SYSTEM_PROPERTY_CREATE_DEFAULT_TABLE_ALIAS
flag actually properly disables the alias table without breaking stuff.
    
    A bit the same with contexts that uses super(false)... Just to make sure that everything
is (and keeps being) consistent.


---

Mime
View raw message