metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From LosD <...@git.apache.org>
Subject [GitHub] metamodel pull request #165: METAMODEL-1165: Add alias default table
Date Tue, 31 Oct 2017 21:06:38 GMT
Github user LosD commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/165#discussion_r148127021
  
    --- Diff: core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ---
    @@ -235,38 +240,28 @@ private boolean isSimpleSelect(SelectClause clause) {
         }
     
         /**
    -     * Executes a simple count query, if possible. This method is provided to
    -     * allow subclasses to optimize count queries since they are quite common
    -     * and often a datastore can retrieve the count using some specialized means
    -     * which is much more performant than counting all records manually.
    +     * Executes a simple count query, if possible. This method is provided to allow subclasses
to optimize count queries
    +     * since they are quite common and often a datastore can retrieve the count using
some specialized means which is
    +     * much more performant than counting all records manually.
          * 
    -     * @param table
    -     *            the table on which the count is requested.
    -     * @param whereItems
    -     *            a (sometimes empty) list of WHERE items.
    -     * @param functionApproximationAllowed
    -     *            whether approximation is allowed or not.
    +     * @param table the table on which the count is requested.
    +     * @param whereItems a (sometimes empty) list of WHERE items.
    +     * @param functionApproximationAllowed whether approximation is allowed or not.
          * @return the count of the particular table, or null if not available.
          */
         protected Number executeCountQuery(Table table, List<FilterItem> whereItems,
boolean functionApproximationAllowed) {
             return null;
         }
     
         /**
    -     * Executes a query which obtains a row by primary key (as defined by
    -     * {@link Column#isPrimaryKey()}). This method is provided to allow
    -     * subclasses to optimize lookup queries since they are quite common and
    -     * often a datastore can retrieve the row using some specialized means which
    -     * is much more performant than scanning all records manually.
    +     * Executes a query which obtains a row by primary key (as defined by {@link Column#isPrimaryKey()}).
This method is
    +     * provided to allow subclasses to optimize lookup queries since they are quite common
and often a datastore can
    +     * retrieve the row using some specialized means which is much more performant than
scanning all records manually.
    --- End diff --
    
    Unrelated change.


---

Mime
View raw message