metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From LosD <...@git.apache.org>
Subject [GitHub] metamodel issue #156: Checkstyle integration
Date Thu, 31 Aug 2017 17:43:47 GMT
Github user LosD commented on the issue:

    https://github.com/apache/metamodel/pull/156
  
    I disagree about the last two points. Both are clear indicators of misdesigned classes.
If a constructor or method requires that many arguments, the class represents too much, or
the method has too many jobs.
    
    Same with complexity. A properly designed class does not need complex methods.
    
    Of course there are exceptions. But in those cases it can be disabled using comments (but
there should be a good argument for doing that). 
    
    The best argument against it is that there's a lot of terrible code (when looking at with
argument list length and complexity googles), so a lot of exceptions are needed. And since
we're way too generous with public classes, all core classes are essentially API classes,
so we can't even fix those step by step, but have to change them big-bang style, which scares
the hell out of me. OTOH, it's nice to highlight classes that needs work when a chance shows
itself. But I must admit we never enabled it in DataCleaner for that exact reason.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message