metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tomatophantastico <...@git.apache.org>
Subject [GitHub] metamodel issue #158: METAMODEL-1161: Max rows without offset and order by
Date Thu, 24 Aug 2017 16:25:44 GMT
Github user tomatophantastico commented on the issue:

    https://github.com/apache/metamodel/pull/158
  
    I found those "toString" test to be quite problematic too, even in small tests and i 
encountered a lot of them during the arrays->collection conversion and i would be happy
to see them phased out, even the small ones.
    
    The schema uses a lot of  interfaces but tests against the string serialisation, which
is meant for human consumption. 
    
    `assertTrue(Lists.newArrayList("a","b").equals(table.getColumnNames()))`
    
    is short, but does not depend on the toString() of the implementing List. 
    
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message