metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From LosD <...@git.apache.org>
Subject [GitHub] metamodel-membrane issue #6: METAMODEL-1150: Docker build (and a bit more)
Date Mon, 21 Aug 2017 08:30:12 GMT
Github user LosD commented on the issue:

    https://github.com/apache/metamodel-membrane/pull/6
  
    Docker changes LGTM.
    
    Regarding the Postman tests, I guess they're good in itself, but pretty useless as integration
tests, unless you can find a way to make Travis run them.
    
    Tests that you need to run manually are usually worth close to nothing, unless someone
has a job description that says "you need to run these manually", which we are a bit low on
in MetaModel :slightly_smiling_face:. Sooner or later they _will_ be obsolete and then they
_will_ be ignored.
    
    I guess we can merge as is, but I'd move to proper Maven+Junit integration tests ASAP
(there's reasonably good tools for running a docker image using Maven that should also work
with Travis, though I think we'll need make PG and Mongo Travis-run to stay within memory
limits). I'll see if I can get a bit of time for implementing soon-ish.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message