metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kaspersorensen <...@git.apache.org>
Subject [GitHub] metamodel issue #156: Checkstyle integration
Date Tue, 08 Aug 2017 02:05:52 GMT
Github user kaspersorensen commented on the issue:

    https://github.com/apache/metamodel/pull/156
  
    My opinion of checkstyle is a bit mixed. Essentially I feel that there is a pitfall which
is that it makes it hard for people to contribute good code if their tool has very minor discrepancies
with the code style. That said, I think a minimum set is very nice to have in place...
    
    One of the things I notice here though is the import statement ordering. I believe that
99% of our codebase today is sorted using eclipse's standard settings. If we require some
other ordering then my next question is: How do we explain to contributors (myself included)
how to set up their IDE. This should essentially be documented, probably in the CONTRIBUTE.md
file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message