metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kaspersorensen <...@git.apache.org>
Subject [GitHub] metamodel pull request #156: Checkstyle integration
Date Tue, 08 Aug 2017 02:01:02 GMT
Github user kaspersorensen commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/156#discussion_r131805889
  
    --- Diff: pom.xml ---
    @@ -330,6 +330,27 @@ under the License.
     				</executions>
     			</plugin>
     
    +			<plugin>
    +				<groupId>org.apache.maven.plugins</groupId>
    +				<artifactId>maven-checkstyle-plugin</artifactId>
    +				<version>2.17</version>
    +				<executions>
    +					<execution>
    +						<id>test</id>
    +						<phase>test</phase>
    +						<configuration>
    +							<configLocation>style/checkstyle.xml</configLocation>
    --- End diff --
    
    Eh ok ... I should have read a bit further! :-) I think we should rename the folder to
"checkstyle" then.
    
    As for the license header check - we already have the `apache-rat-plugin` which also does
some of this. Could seem that it's less complete though. We might want to sync them up to
avoid double work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message