metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tomatophantastico <...@git.apache.org>
Subject [GitHub] metamodel pull request #153: Collections instead of Arrays
Date Fri, 28 Jul 2017 12:07:17 GMT
Github user tomatophantastico commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/153#discussion_r130074475
  
    --- Diff: core/src/main/java/org/apache/metamodel/data/AbstractRowBuilder.java ---
    @@ -68,7 +71,7 @@ public AbstractRowBuilder(Column[] columns) {
     
         @Override
         public final Row toRow() {
    -        return new DefaultRow(new SimpleDataSetHeader(_columns), _values);
    +        return new DefaultRow(new SimpleDataSetHeader(Arrays.stream(_columns).map(SelectItem::new).collect(Collectors.toList())),
_values);
    --- End diff --
    
    Array and List have a slight different semantic.
    My reasoning was, if i can grasp the code within a minute, i changed internal methods,
otherwise preserve it.
    
    This is especially the case with the XML-Dom-related stuff.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message