metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tomatophantastico <...@git.apache.org>
Subject [GitHub] metamodel pull request #150: Feature/quote columns
Date Sat, 22 Jul 2017 19:43:45 GMT
Github user tomatophantastico commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/150#discussion_r128903712
  
    --- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/DefaultQueryRewriter.java
---
    @@ -101,7 +101,7 @@ public String rewriteColumnType(ColumnType columnType, Integer columnSize)
{
             return super.rewriteColumnType(columnType, columnSize);
         }
     
    -    private boolean needsQuoting(String alias, String identifierQuoteString) {
    +    public boolean needsQuoting(String alias, String identifierQuoteString) {
    --- End diff --
    
    agreed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message