metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From LosD <...@git.apache.org>
Subject [GitHub] metamodel pull request #137: Metamodel 1132 sql native paging
Date Fri, 09 Dec 2016 12:38:07 GMT
Github user LosD commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/137#discussion_r91708656
  
    --- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/SQLServerQueryRewriter.java
---
    @@ -31,15 +33,10 @@
     import org.apache.metamodel.schema.ColumnType;
     import org.apache.metamodel.util.DateUtils;
     
    -public class SQLServerQueryRewriter extends DefaultQueryRewriter {
    +public class SQLServerQueryRewriter extends OffsetFetchQueryRewriter {
     
         public SQLServerQueryRewriter(JdbcDataContext dataContext) {
    -        super(dataContext);
    -    }
    -
    -    @Override
    -    public boolean isMaxRowsSupported() {
    -        return true;
    +        super(dataContext, 11);
    --- End diff --
    
    Also magic number here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message