metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From LosD <...@git.apache.org>
Subject [GitHub] metamodel issue #132: MSSQL datetime format language neutral
Date Wed, 12 Oct 2016 08:05:15 GMT
Github user LosD commented on the issue:

    https://github.com/apache/metamodel/pull/132
  
    I believe the integration tests @kaspersorensen is talking about are the one in the JDBC
module which are configured by copying the `example-metamodel-integrationtest-configuration.properties`
file to `~/metamodel-integrationtest-configuration.properties`, then uncommenting and configuring
the `jdbc.sqlserver.` properties. Please note that you will need the AdventureWorks database.
    
    However, I wouldn't bother, unless you also feel like fixing the tests. There's failures
relating to tables not being in the "correct" order in the schema, times being compared using
exact string matches (SQL Server timestamps can change by +/- 3ms), and other failures<sup>1</sup>.
    
    The good news is that, testWorkingWithDates was happy when I tried, so I guess that means
that your change didn't break anything.
    
    It's weird that Cassandra fails for you, by the way. My only issue is that the test dumps
a `.toDelete` file in the Cassandra folder that I need to nuke for the license check to stay
happy.
    
    <sup>1</sup> One of them might be a real issue, though. `new Query().select("Name")`
fails with "Not capable of parsing SELECT token: Name") on line 185. Doesn't seem related
to your change, though.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message