Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4EA40200B5B for ; Fri, 5 Aug 2016 08:58:47 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4D07D160A8E; Fri, 5 Aug 2016 06:58:47 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 92DE4160A6D for ; Fri, 5 Aug 2016 08:58:46 +0200 (CEST) Received: (qmail 20156 invoked by uid 500); 5 Aug 2016 06:58:45 -0000 Mailing-List: contact dev-help@metamodel.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@metamodel.apache.org Delivered-To: mailing list dev@metamodel.apache.org Received: (qmail 20145 invoked by uid 99); 5 Aug 2016 06:58:45 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Aug 2016 06:58:45 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 4820CEC22C; Fri, 5 Aug 2016 06:58:45 +0000 (UTC) From: jhorcicka To: dev@metamodel.apache.org Reply-To: dev@metamodel.apache.org Message-ID: Subject: [GitHub] metamodel pull request #121: FixedWidthReader diacritics bug fix Content-Type: text/plain Date: Fri, 5 Aug 2016 06:58:45 +0000 (UTC) archived-at: Fri, 05 Aug 2016 06:58:47 -0000 GitHub user jhorcicka opened a pull request: https://github.com/apache/metamodel/pull/121 FixedWidthReader diacritics bug fix Refactoring of FixedWidthReader in PR https://github.com/apache/metamodel/pull/103 introduced a bug related to charset (which was not used). So, input containing diacritic characters was not read correctly. JUnit FixedWidthReaderTest was updated with charset tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jhorcicka/metamodel master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metamodel/pull/121.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #121 ---- commit 480f71af754f08d53891f40d9ff9c27822fec62b Author: jhorcicka Date: 2016-05-20T11:26:23Z METAMODEL-250 FixedWidth EBCDIC support: headerPresent and eolPresent options; Reader was replaced by InputStream; commit ca3ef6cf93f4cfd6f0dc7854aa23d0bd2f75868d Author: jhorcicka Date: 2016-05-20T12:39:04Z METAMODEL-250 FixedWidthConfiguration: formatting. commit 35d9b6d1b861a9d60b848614673c1fb98165bc1c Author: jhorcicka Date: 2016-05-23T07:00:24Z METAMODEL-250 FixedWidthReader: refactoring of "throwInconsistentValueException". commit f7b9ad7c036100b11607eae5e4185161a595b3c4 Author: jhorcicka Date: 2016-05-23T07:08:58Z METAMODEL-250 FixedWidthConfiguration overloaded constructor: default values for new properties => backwards compatibility. commit 897117d8be90b6a5b4259b69c480d6c1e722dbc8 Author: jhorcicka Date: 2016-08-01T11:27:41Z METAMODEL-250 Ebcdic Configuration and Reader were separated (sub-classed) from FixedWidth parents so that EBCDIC-specific properties are handled in separated classes. commit c0526d09829e43b4372d6a3d36d09dcdb1f983e1 Author: jhorcicka Date: 2016-08-01T13:49:12Z METAMODEL-250 Code cleanup. commit d0672c76d56d2449778fa836104c2192723f19ce Author: jhorcicka Date: 2016-08-01T13:55:02Z Merge branch 'upstream-master' # Conflicts: # fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthReader.java commit 513fa907299885f50cd0ccbd6f01654869e9e0b4 Author: jhorcicka Date: 2016-08-01T14:14:38Z METAMODEL-250 test corrections. commit 5d1d8e07de2de4f36ddaafd686552e02b373a83b Author: jhorcicka Date: 2016-08-01T14:26:39Z METAMODEL-250 EbcdicReader: _headerPresent was renamed to _skipEbcdicHeader. commit 257420a9a75f510f54a05a9871593274194793cb Author: jhorcicka Date: 2016-08-03T14:46:10Z METAMODEL-250 FixedWidthReader: encoding problem was fixed. commit e8ac28efa6fa4e994203fceacb7fbffcbea55246 Author: jhorcicka Date: 2016-08-03T14:54:22Z Merge branch 'upstream-master' # Conflicts: # fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthReader.java commit a54b7588c995b333a2fa99cc000f6fdbbf7c28cd Author: jhorcicka Date: 2016-08-04T07:56:23Z METAMODEL-250 FixedWidthReader: junit tests for diacritics were added. ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---