metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kaspersorensen <...@git.apache.org>
Subject [GitHub] metamodel pull request #127: Adding 2 more columns END and TABLE
Date Tue, 30 Aug 2016 20:40:00 GMT
Github user kaspersorensen commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/127#discussion_r76874584
  
    --- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/SqlKeywords.java ---
    @@ -58,6 +58,8 @@
             KEYWORDS.add("DELETE");
             KEYWORDS.add("AND");
             KEYWORDS.add("OR");
    +        KEYWORDS.add("END");
    --- End diff --
    
    I don't worry at all about the performance here because it is still a pretty small set
and it happens just once. I worry a bit about maintaining this keyword list though, but that's
a conversation that maybe goes beyond the scope of this little fix. I will merge it in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message