Mailing-List: contact dev-help@metamodel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@metamodel.apache.org
From: LosD <git@git.apache.org>
To: dev@metamodel.apache.org
Reply-To: dev@metamodel.apache.org
References: <git-pr-113-metamodel@git.apache.org>
In-Reply-To: <git-pr-113-metamodel@git.apache.org>
Subject: [GitHub] metamodel pull request #113: Dynamic DataContext factory (MM 1099)
Content-Type: text/plain
Message-Id: <20160706062051.42C39E01C1@git1-us-west.apache.org>
Date: Wed,  6 Jul 2016 06:20:51 +0000 (UTC)
archived-at: Wed, 06 Jul 2016 06:20:53 -0000

Github user LosD commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/113#discussion_r69680105
  
    --- Diff: core/src/main/java/org/apache/metamodel/util/ResourceUtils.java ---
    @@ -18,11 +18,31 @@
      */
     package org.apache.metamodel.util;
     
    +import java.net.URI;
    +
    +import org.apache.metamodel.factory.ResourceFactoryRegistryImpl;
    +import org.apache.metamodel.factory.ResourceProperties;
    +import org.apache.metamodel.factory.SimpleResourceProperties;
    +import org.apache.metamodel.factory.UnsupportedResourcePropertiesException;
    +
     /**
      * Static utility methods for handling {@link Resource}s.
      */
     public class ResourceUtils {
     
    +    public static Resource toResource(URI uri) {
    +        return toResource(new SimpleResourceProperties(uri));
    +    }
    +
    +    public static Resource toResource(String uri) {
    +        return toResource(new SimpleResourceProperties(uri));
    +    }
    +
    +    public static Resource toResource(ResourceProperties resourceProperties)
    +            throws UnsupportedResourcePropertiesException {
    --- End diff --
    
    Here's one of the examples I talked about. Why do this declared the throwing, when the overloaded methods (just above) does not, even though they just call this (along with a constructor)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---