Mailing-List: contact dev-help@metamodel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@metamodel.apache.org
From: LosD <git@git.apache.org>
To: dev@metamodel.apache.org
Reply-To: dev@metamodel.apache.org
Message-ID: <git-pr-107-metamodel@git.apache.org>
Subject: [GitHub] metamodel pull request #107: METAMODEL-1093 close compiled ResultSets
Content-Type: text/plain
Date: Fri,  3 Jun 2016 10:09:57 +0000 (UTC)
archived-at: Fri, 03 Jun 2016 10:09:59 -0000

GitHub user LosD opened a pull request:

    https://github.com/apache/metamodel/pull/107

    METAMODEL-1093 close compiled ResultSets

    This makes sure that ResultSets are closed JdbcDataSet itselfs closes. Also refactors closing of Statements and ResultsSets to use try-with-resources as much as possible. This also moves the responsibility of closing Statements and ResultSets away from JdbcDataContext, which seems to belong more to the caller, since the context isn't the one to actually track them even though it creates them (and it is of course a requirement for using try-with-resources).
    
    Fixes METAMODEL-1093

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/LosD/metamodel mm-close-dataset

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metamodel/pull/107.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #107
    
----
commit 7ccb446a846acd856abfee8526d19d4d05b77785
Author: Dennis Du Krøger <dennis.dukroger@humaninference.com>
Date:   2016-05-12T09:35:18Z

    Do already-loaded check before retrieving connection.
    
    Fixes METAMODEL-252

commit 2c751ab452e4e327790bb8565ff7acc3fa1d563a
Author: Dennis Du Krøger <dennis.dukroger@humaninference.com>
Date:   2016-05-23T12:33:47Z

    Merge remote-tracking branch 'origin/master'

commit 456815b76bb69f88afd27d83c9794bcb8da76cad
Author: Dennis Du Krøger <dennis.dukroger@humaninference.com>
Date:   2016-06-02T07:47:24Z

    Merge remote-tracking branch 'origin/master'

commit 89dd268cee63410373f893e2f38a02059bab876b
Author: Dennis Du Krøger <dennis.dukroger@humaninference.com>
Date:   2016-06-02T13:47:25Z

    Better control of closing resources.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---