Mailing-List: contact dev-help@metamodel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@metamodel.apache.org
From: kaspersorensen <git@git.apache.org>
To: dev@metamodel.apache.org
Reply-To: dev@metamodel.apache.org
References: <git-pr-103-metamodel@git.apache.org>
In-Reply-To: <git-pr-103-metamodel@git.apache.org>
Subject: [GitHub] metamodel pull request #103: FixedWidth EBCDIC support
Content-Type: text/plain
Message-Id: <20160609041410.B73F8DFC71@git1-us-west.apache.org>
Date: Thu,  9 Jun 2016 04:14:10 +0000 (UTC)
archived-at: Thu, 09 Jun 2016 04:14:13 -0000

Github user kaspersorensen commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/103#discussion_r66380408
  
    --- Diff: fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthConfiguration.java ---
    @@ -33,66 +33,74 @@
     /**
      * Configuration of metadata about a fixed width values datacontext.
      */
    -public final class FixedWidthConfiguration extends BaseObject implements
    -		Serializable {
    +public final class FixedWidthConfiguration extends BaseObject implements Serializable {
     
    -	private static final long serialVersionUID = 1L;
    +    private static final long serialVersionUID = 1L;
     
    -	public static final int NO_COLUMN_NAME_LINE = 0;
    -	public static final int DEFAULT_COLUMN_NAME_LINE = 1;
    +    public static final int NO_COLUMN_NAME_LINE = 0;
    +    public static final int DEFAULT_COLUMN_NAME_LINE = 1;
     
    -	private final String encoding;
    -	private final int fixedValueWidth;
    -	private final int[] valueWidths;
    -	private final int columnNameLineNumber;
    -	private final boolean failOnInconsistentLineWidth;
    -	private final ColumnNamingStrategy columnNamingStrategy;
    +    private final String encoding;
    +    private final int fixedValueWidth;
    +    private final int[] valueWidths;
    +    private final int columnNameLineNumber;
    +    private final boolean failOnInconsistentLineWidth;
    +    private final boolean headerPresent;
    --- End diff --
    
    This new property is redundant (and thus potentially 'dirty') because `columnNameLineNumber` holds the same metadata. If it is 0 (`NO_COLUMN_NAME_LINE `), then it means that there is no header.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---