metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kaspersorensen <...@git.apache.org>
Subject [GitHub] metamodel pull request #103: FixedWidth EBCDIC support
Date Fri, 17 Jun 2016 19:06:35 GMT
Github user kaspersorensen commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/103#discussion_r67560331
  
    --- Diff: fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthConfiguration.java
---
    @@ -33,66 +33,74 @@
     /**
      * Configuration of metadata about a fixed width values datacontext.
      */
    -public final class FixedWidthConfiguration extends BaseObject implements
    -		Serializable {
    +public final class FixedWidthConfiguration extends BaseObject implements Serializable
{
     
    -	private static final long serialVersionUID = 1L;
    +    private static final long serialVersionUID = 1L;
     
    -	public static final int NO_COLUMN_NAME_LINE = 0;
    -	public static final int DEFAULT_COLUMN_NAME_LINE = 1;
    +    public static final int NO_COLUMN_NAME_LINE = 0;
    +    public static final int DEFAULT_COLUMN_NAME_LINE = 1;
     
    -	private final String encoding;
    -	private final int fixedValueWidth;
    -	private final int[] valueWidths;
    -	private final int columnNameLineNumber;
    -	private final boolean failOnInconsistentLineWidth;
    -	private final ColumnNamingStrategy columnNamingStrategy;
    +    private final String encoding;
    +    private final int fixedValueWidth;
    +    private final int[] valueWidths;
    +    private final int columnNameLineNumber;
    +    private final boolean failOnInconsistentLineWidth;
    +    private final boolean headerPresent;
    --- End diff --
    
    I would actually then prefer that we subclass it. Remove the 'final' part of the FixedWidthConfiguration
and make an EbcdicConfiguration class that extends it. That way we don't introduce something
into this class that is still not a very well-defined thing. For that you have my green :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message