metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jhorcicka <...@git.apache.org>
Subject [GitHub] metamodel pull request #103: FixedWidth EBCDIC support
Date Mon, 13 Jun 2016 06:56:58 GMT
Github user jhorcicka commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/103#discussion_r66746248
  
    --- Diff: fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthConfiguration.java
---
    @@ -33,66 +33,74 @@
     /**
      * Configuration of metadata about a fixed width values datacontext.
      */
    -public final class FixedWidthConfiguration extends BaseObject implements
    -		Serializable {
    +public final class FixedWidthConfiguration extends BaseObject implements Serializable
{
     
    -	private static final long serialVersionUID = 1L;
    +    private static final long serialVersionUID = 1L;
     
    -	public static final int NO_COLUMN_NAME_LINE = 0;
    -	public static final int DEFAULT_COLUMN_NAME_LINE = 1;
    +    public static final int NO_COLUMN_NAME_LINE = 0;
    +    public static final int DEFAULT_COLUMN_NAME_LINE = 1;
     
    -	private final String encoding;
    -	private final int fixedValueWidth;
    -	private final int[] valueWidths;
    -	private final int columnNameLineNumber;
    -	private final boolean failOnInconsistentLineWidth;
    -	private final ColumnNamingStrategy columnNamingStrategy;
    +    private final String encoding;
    +    private final int fixedValueWidth;
    +    private final int[] valueWidths;
    +    private final int columnNameLineNumber;
    +    private final boolean failOnInconsistentLineWidth;
    +    private final boolean headerPresent;
    --- End diff --
    
    Yes, let's give it a better name. I am not too much into "padding" since some padding
is actually in all rows. Basically this "binary header" contains some additional data about
the file, so what about `metadataPresent`? Would that be clear to the users?  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message