metamodel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kaspersorensen <...@git.apache.org>
Subject [GitHub] metamodel pull request #109: Improving writing to an excel file
Date Thu, 09 Jun 2016 04:09:29 GMT
Github user kaspersorensen commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/109#discussion_r66380131
  
    --- Diff: excel/src/main/java/org/apache/metamodel/excel/ExcelUtils.java ---
    @@ -153,20 +155,15 @@ public static Workbook readWorkbook(ExcelDataContext dataContext)
{
          * @param wb
          */
         public static void writeAndCloseWorkbook(ExcelDataContext dataContext, final Workbook
wb) {
    -        // first write to a temp file to avoid that workbook source is the same
    -        // as the target (will cause read+write cyclic overflow)
    --- End diff --
    
    I think the gist of this is just that you're disregarding this comment now? That would
cause an old bug to reoccur.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message